Skip to content

src: slightly simplify FSEventWrap #21533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
addaleax wants to merge 2 commits into from
Closed

src: slightly simplify FSEventWrap #21533

addaleax wants to merge 2 commits into from

Conversation

@addaleax
Copy link
Member

@addaleax addaleax commented Jun 25, 2018

We don’t need to track initialized_, HandleWrap already does
that for us.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@addaleax
src: slightly simplify FSEventWrap
578fcce 
We don’t need to track `initialized_`, `HandleWrap` already does
that for us.
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 25, 2018

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/158/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. labels Jun 25, 2018
@addaleax
Copy link
Member Author

addaleax commented Jun 25, 2018

CI: https://ci.nodejs.org/job/node-test-commit/19458/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 25, 2018
bnoordhuis
bnoordhuis approved these changes Jun 26, 2018
View reviewed changes
src/fs_event_wrap.cc Outdated
AsyncWrap::AddWrapMethods(env, t);
env->SetProtoMethod(t, "start", Start);
env->SetProtoMethod(t, "close", Close);
env->SetProtoMethod(t, "close", HandleWrap::Close);
Copy link
Member

@bnoordhuis bnoordhuis Jun 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd use unqualified Close, that turns it into a build error if FSEventWrap stops being a HandleWrap.

Copy link
Member Author

@addaleax addaleax Jun 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@addaleax
Copy link
Member Author

addaleax commented Jun 26, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/15629/

jasnell pushed a commit that referenced this pull request Jun 29, 2018
@addaleax @jasnell
src: slightly simplify FSEventWrap
bf360d2 
We don’t need to track `initialized_`, `HandleWrap` already does
that for us.

PR-URL: #21533
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Jun 29, 2018

Landed in bf360d2

@jasnell jasnell closed this Jun 29, 2018
targos pushed a commit that referenced this pull request Jun 29, 2018
@addaleax @targos
src: slightly simplify FSEventWrap
bb0795a 
We don’t need to track `initialized_`, `HandleWrap` already does
that for us.

PR-URL: #21533
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Jul 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

+2 more reviewers

@apapirovski apapirovski apapirovski approved these changes

@eugeneo eugeneo eugeneo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@addaleax @nodejs-github-bot @jasnell @apapirovski @bnoordhuis @eugeneo @cjihrig @joyeecheung