Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix setUncaughtExceptionCaptureCallback name in body text #21523

Closed
wants to merge 1 commit into from
Closed

doc: fix setUncaughtExceptionCaptureCallback name in body text #21523

wants to merge 1 commit into from

Conversation

rjoonas
Copy link

@rjoonas rjoonas commented Jun 25, 2018

Name of this function was misspelled in its Process docs, so I changed setUncaughtExceptionCapture to setUncaughtExceptionCaptureCallback.

process.setUncaughtExceptionCaptureCallback and its docs were originally added in #17159

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels Jun 25, 2018
setUncaughtExceptionCapture -> setUncaughtExceptionCaptureCallback

process.setUncaughtExceptionCaptureCallback and its docs were originally
added in #17159

PR-URL: #21523
@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 25, 2018
@trivikr
Copy link
Member

trivikr commented Jun 25, 2018

@rjoonas Thanks for the find, and the PR! 😄

@trivikr
Copy link
Member

trivikr commented Jun 25, 2018

@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 25, 2018
@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt vsemozhetbyt removed the fast-track PRs that do not need to wait for 48 hours to land. label Jun 27, 2018
vsemozhetbyt pushed a commit that referenced this pull request Jun 27, 2018
setUncaughtExceptionCapture -> setUncaughtExceptionCaptureCallback

process.setUncaughtExceptionCaptureCallback and its docs were originally
added in #17159

PR-URL: #21523
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@vsemozhetbyt
Copy link
Contributor

Landed in 1f6adff
I've added one missing parentheses after the function name (as per our style guide) while landing.

Thank you, @rjoonas!

targos pushed a commit that referenced this pull request Jun 28, 2018
setUncaughtExceptionCapture -> setUncaughtExceptionCaptureCallback

process.setUncaughtExceptionCaptureCallback and its docs were originally
added in #17159

PR-URL: #21523
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@targos targos mentioned this pull request Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants