[8.x] deps: V8: fix bug in InternalPerformPromiseThen #21426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
v8 engine
ofrobots
changed the title
bnoordhuis
approved these changes
Jun 20, 2018
| @@ -509,8 +509,8 @@ Node* PromiseBuiltinsAssembler::InternalPerformPromiseThen( | |||
| BIND(&if_existingcallbacks); | |||
| { | |||
| Label if_singlecallback(this), if_multiplecallbacks(this); | |||
| BranchIfJSObject(existing_deferred_promise, &if_singlecallback, | |||
| &if_multiplecallbacks); | |||
| Branch(HasInstanceType(existing_deferred_promise, FIXED_ARRAY_TYPE), | |||
There was a problem hiding this comment.
You could also use Branch(IsFixedArray(existing_deferred_promise), ...) here.
There was a problem hiding this comment.
/cc @sigurdschneider
ofrobots
added
blocked
This fix never landed upstream as it was not longer relevant to active V8 branches for Chromium. Original commit message: [turbofan] Fix bug in InternalPerformPromiseThen Bug: chromium:831170 Change-Id: I1022fc360aafdfd392d6781eb50afc87a18096fd PR-URL: nodejs#21426 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
Landed on |
Merged
rvagg
pushed a commit
that referenced
this pull request
Aug 16, 2018
This fix never landed upstream as it was not longer relevant to active V8 branches for Chromium. Original commit message: [turbofan] Fix bug in InternalPerformPromiseThen Bug: chromium:831170 Change-Id: I1022fc360aafdfd392d6781eb50afc87a18096fd PR-URL: #21426 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix never landed upstream as it was not longer relevant to active V8 branches for Chromium.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes/cc @nodejs/v8
@mhdawson this PR is also going to be blocked because of the infra issues with the V8-CI
CI: https://ci.nodejs.org/job/node-test-pull-request/15541/
V8-CI: https://ci.nodejs.org/view/All/job/node-test-commit-v8-linux/1498/