Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: refer to correct deprecation id in comment #21399

Closed
wants to merge 1 commit into from
Closed

crypto: refer to correct deprecation id in comment #21399

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Jun 19, 2018

No description provided.

@nodejs-github-bot
Copy link
Collaborator

@targos build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/94/pipeline

@nodejs-github-bot nodejs-github-bot added the crypto Issues and PRs related to the crypto subsystem. label Jun 19, 2018
@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 19, 2018
@targos
Copy link
Member Author

targos commented Jun 19, 2018

👍 this comment to fast-track

@targos
Copy link
Member Author

targos commented Jun 20, 2018

Landed in 0eb8a8c

@targos targos closed this Jun 20, 2018
@targos targos deleted the missing-dep branch June 20, 2018 20:03
dnalborczyk pushed a commit to dnalborczyk/node that referenced this pull request Jun 20, 2018
@targos
crypto: refer to correct deprecation id in comment
0eb8a8c 
PR-URL: nodejs#21399
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos added a commit that referenced this pull request Jun 22, 2018
@targos
crypto: refer to correct deprecation id in comment
e7776c6 
PR-URL: #21399
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request Jul 3, 2018
Merged
@snyk-bot snyk-bot mentioned this pull request Mar 18, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@danbev danbev danbev approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
crypto Issues and PRs related to the crypto subsystem. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@targos @nodejs-github-bot @bnoordhuis @danbev @lpinca @cjihrig @richardlau @trivikr