Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test stream writable state #21292

Closed
wants to merge 3 commits into from
Closed

Test stream writable state #21292

wants to merge 3 commits into from

Commits on Jun 12, 2018

  1. Improved test for streamState by removing uneeded error string

    @deleteman
    deleteman committed Jun 12, 2018
    Configuration menu
    Copy the full SHA
    4f84c51 View commit details
    Browse the repository at this point in the history

  2. test: remove string error from strictEquals 

    Removes the string error from the assertion call to
improve the error message shown on screen when the
test fails.
    @deleteman
    deleteman committed Jun 12, 2018
    Configuration menu
    Copy the full SHA
    9fad50b View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2018

  1. test: remove comment added in previous commit 

    Removing a code comment with the error message, due to
feedback from reviewers

reviewers: Ipinca, apapirovski
    @deleteman
    deleteman committed Jun 13, 2018
    Configuration menu
    Copy the full SHA
    eb2547f View commit details
    Browse the repository at this point in the history