-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix typo in addons.md #21137
Closed
Closed
doc: fix typo in addons.md #21137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"across version of Node.js" -> "across versions of Node.js"
nodejs-github-bot
added
addons
Issues and PRs related to native addons.
doc
Issues and PRs related to the documentations.
labels
Jun 5, 2018
vsemozhetbyt
approved these changes
Jun 5, 2018
vsemozhetbyt
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
fast-track
PRs that do not need to wait for 48 hours to land.
labels
Jun 5, 2018
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
trivikr
approved these changes
Jun 5, 2018
targos
approved these changes
Jun 5, 2018
lpinca
approved these changes
Jun 5, 2018
cjihrig
approved these changes
Jun 5, 2018
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jun 6, 2018
"across version of Node.js" -> "across versions of Node.js" PR-URL: nodejs#21137 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Landed in aa08cf1 |
MylesBorins
pushed a commit
that referenced
this pull request
Jun 6, 2018
"across version of Node.js" -> "across versions of Node.js" PR-URL: #21137 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
addons
Issues and PRs related to native addons.
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
fast-track
PRs that do not need to wait for 48 hours to land.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"across version of Node.js" -> "across versions of Node.js"
Checklist