build: fail on instrumentation errors #21071
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyc was silently failing to instrument new language features, resulting in a failure to instrument console.js. Refs: nodejs#20952
nodejs-github-bot
added
the
build
refack
approved these changes
Jun 1, 2018
iarna
approved these changes
Jun 1, 2018
benjamingr
approved these changes
Jun 1, 2018
lpinca
approved these changes
Jun 2, 2018
maclover7
approved these changes
Jun 2, 2018
targos
added
the
author ready
|
Landed in ba4f5e9 |
bcoe
pushed a commit
that referenced
this pull request
Jun 25, 2018
nyc was silently failing to instrument new language features, resulting in a failure to instrument console.js. Refs: #20952 PR-URL: #21071 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Rebecca Turner <me@re-becca.org> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
targos
pushed a commit
that referenced
this pull request
Jun 26, 2018
nyc was silently failing to instrument new language features, resulting in a failure to instrument console.js. Refs: #20952 PR-URL: #21071 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Rebecca Turner <me@re-becca.org> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nyc was silently failing to instrument new language features, resulting in a failure to instrument console.js.
the actual underlying issues are discussed and addressed here:
babel/babel#8075,
istanbuljs/istanbuljs#174,
istanbuljs/istanbuljs#175
In this pull request we enable nyc's logging and new "exit on failure" feature to ensure that we catch behavior like this immediately in the future.
see #20952
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesCC: @BridgeAR, @maclover7