Skip to content

doc: add missing link for 10.3.0 changelog #21017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

doc: add missing link for 10.3.0 changelog #21017

wants to merge 1 commit into from

Conversation

@MylesBorins
Copy link
Contributor

@MylesBorins MylesBorins commented May 29, 2018

please fastrack

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 29, 2018
@MylesBorins MylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label May 29, 2018
@mmarchini
Copy link
Contributor

mmarchini commented May 29, 2018

👍 on fast-tracking

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 29, 2018
@BridgeAR
Copy link
Member

BridgeAR commented May 29, 2018

A CI should not be necessary in this case.

@MylesBorins
Copy link
Contributor Author

MylesBorins commented May 30, 2018

landed in 8976c79

MylesBorins added a commit that referenced this pull request May 30, 2018
@MylesBorins
doc: add missing link for 10.3.0 changelog
8976c79 
PR-URL: #21017
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
addaleax pushed a commit that referenced this pull request May 31, 2018
@MylesBorins @addaleax
doc: add missing link for 10.3.0 changelog
c2ae93d 
PR-URL: #21017
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jun 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

+3 more reviewers

@danbev danbev danbev approved these changes

@maclover7 maclover7 maclover7 approved these changes

@mmarchini mmarchini mmarchini approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@MylesBorins @mmarchini @BridgeAR @danbev @jasnell @lpinca @maclover7 @joyeecheung @trivikr @nodejs-github-bot