Skip to content

lib,src,test: fix comments #20846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tniessen wants to merge 1 commit into from
Closed

lib,src,test: fix comments #20846

tniessen wants to merge 1 commit into from

Conversation

@tniessen
Copy link
Member

@tniessen tniessen commented May 20, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels May 20, 2018
@BridgeAR BridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label May 20, 2018
@BridgeAR
Copy link
Member

BridgeAR commented May 20, 2018

CI https://ci.nodejs.org/job/node-test-pull-request-lite/736/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 20, 2018
@richardlau
Copy link
Member

richardlau commented May 21, 2018

Explicit +1 for fast tracking.

@apapirovski
Copy link
Contributor

apapirovski commented May 22, 2018

Landed in e316655

apapirovski pushed a commit that referenced this pull request May 22, 2018
@tniessen @apapirovski
lib,src,test: fix comments
e316655 
PR-URL: #20846
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins pushed a commit that referenced this pull request May 22, 2018
@tniessen @MylesBorins
lib,src,test: fix comments
1f01830 
PR-URL: #20846
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@addaleax addaleax mentioned this pull request May 22, 2018
Merged
MylesBorins pushed a commit that referenced this pull request May 23, 2018
@tniessen @MylesBorins
lib,src,test: fix comments
8d8b0bd 
PR-URL: #20846
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@tniessen tniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

+1 more reviewer

@danbev danbev danbev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@tniessen @BridgeAR @richardlau @apapirovski @danbev @jasnell @cjihrig @nodejs-github-bot