Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls: move convertNPNProtocols to End-of-Life #20736

Closed
wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented May 15, 2018

This was deprecated in 10.0.0 because NPN support was removed.
It does not make sense to keep this around longer than 10.x

/cc @bnoordhuis

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

This was deprecated in 10.0.0 because NPN support was removed.
It does not make sense to keep this around longer than 10.x
@jasnell jasnell added semver-major PRs that contain breaking changes and should be released in the next major version. deprecations Issues and PRs related to deprecations. labels May 15, 2018
@nodejs-github-bot nodejs-github-bot added the tls Issues and PRs related to the tls subsystem. label May 15, 2018
@jasnell jasnell requested a review from bnoordhuis May 15, 2018 01:17
@Trott
Copy link
Member

Trott commented May 15, 2018

@nodejs/crypto

@targos targos requested a review from a team May 15, 2018 08:04
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BridgeAR
Copy link
Member

CI https://ci.nodejs.org/job/node-test-pull-request/14878/

@ all former reviewers and James: please start the CI when opening a PR / when giving a LG :-)

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 15, 2018
@jasnell
Copy link
Member Author

jasnell commented May 15, 2018

CI looks good overall, AIX build bot failed, running again to be safe: https://ci.nodejs.org/job/node-test-commit-aix/15007/

@jasnell
Copy link
Member Author

jasnell commented May 15, 2018

@nodejs/build @nodejs/platform-aix ... The AIX build bot is failing with a compiler error.

@Trott
Copy link
Member

Trott commented May 15, 2018

AIX build issue was fixed by @mhdawson (or at least he reported it was fixed if he didn't fix it himself) so re-running now: https://ci.nodejs.org/job/node-test-commit-aix/15025/

jasnell added a commit that referenced this pull request May 17, 2018
This was deprecated in 10.0.0 because NPN support was removed.
It does not make sense to keep this around longer than 10.x

PR-URL: #20736
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
@jasnell
Copy link
Member Author

jasnell commented May 17, 2018

Landed in 4d00cd4

@jasnell jasnell closed this May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. deprecations Issues and PRs related to deprecations. semver-major PRs that contain breaking changes and should be released in the next major version. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.