Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dns: default to verbatim=true in dns.lookup() #20710

Closed
wants to merge 3 commits into from
Closed

dns: default to verbatim=true in dns.lookup() #20710

wants to merge 3 commits into from

Commits on Nov 30, 2018

  1. dns: default to verbatim=true in dns.lookup() 

    Switch the default from false (reorder the result so that IPv4 addresses
come before IPv6 addresses) to true (return them exactly as the resolver
sent them to us.)
    @bnoordhuis @Trott
    bnoordhuis authored and Trott committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    292a1ed View commit details
    Browse the repository at this point in the history

  2. squash! test fixups

    @bnoordhuis @Trott
    bnoordhuis authored and Trott committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    55fb3ab View commit details
    Browse the repository at this point in the history

  3. test: get rid of common.localhostIPv4 

    This was ostensibly introduced to make the test suite run inside a
FreeBSD jail (why?) but the liberal use of the '127.0.0.1' string
literal all across the test suite is IMO a good indicator that it
bitrotted.

A test suite without `common.localhostIPv4` is an infinitesimally
easier to comprehend test suite so let's get rid of it.
    @bnoordhuis @Trott
    bnoordhuis authored and Trott committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    3e8af64 View commit details
    Browse the repository at this point in the history