tools: delete redundant .eslintignore rule #20203
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `node_modules` rule below is treated as a glob pattern, so it includes the `tools/node_modules` folder. Refs: https://eslint.org/docs/user-guide/configuring#ignoring-files-and-directories Refs: https://git-scm.com/docs/gitignore#_pattern_format
vsemozhetbyt
added
the
fast-track
|
Please, add 👍 here to approve fast-tracking. |
Trott
approved these changes
Apr 21, 2018
vsemozhetbyt
added
the
author ready
cjihrig
approved these changes
Apr 21, 2018
devsnek
approved these changes
Apr 21, 2018
vsemozhetbyt
added a commit
that referenced
this pull request
Apr 21, 2018
The `node_modules` rule below is treated as a glob pattern, so it includes the `tools/node_modules` folder. PR-URL: #20203 Refs: https://eslint.org/docs/user-guide/configuring#ignoring-files-and-directories Refs: https://git-scm.com/docs/gitignore#_pattern_format Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
|
Landed in a8b891c |
jasnell
pushed a commit
that referenced
this pull request
Apr 23, 2018
The `node_modules` rule below is treated as a glob pattern, so it includes the `tools/node_modules` folder. PR-URL: #20203 Refs: https://eslint.org/docs/user-guide/configuring#ignoring-files-and-directories Refs: https://git-scm.com/docs/gitignore#_pattern_format Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesThe
node_modulesrule below is treated as a glob pattern, so it includes thetools/node_modulesfolder.Refs: https://eslint.org/docs/user-guide/configuring#ignoring-files-and-directories
Refs: https://git-scm.com/docs/gitignore#_pattern_format