deps: cherry-pick 39d546a from upstream v8 #20016

devsnek · 2018-04-13T19:23:21Z

Two commits here:

[api] introduce v8::Value::IsModuleNamespaceObject (v8/v8@39d546a)
util: introduce isModuleNamespaceObject (ff9eba9e4dfd99f5d5d3f4963e3703a3128cc6f0)

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

bnoordhuis · 2018-04-13T19:25:24Z

deps/v8/AUTHORS

@@ -70,6 +70,7 @@ Felix Geisendörfer <haimuiba@gmail.com>
 Filipe David Manana <fdmanana@gmail.com>
 Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
 Geoffrey Garside <ggarside@gmail.com>
+Gus Caplan <me@gus.host>


Congrats on your first V8 commit. :-)

devsnek · 2018-04-13T19:34:50Z

CI https://ci.nodejs.org/job/node-test-pull-request/14271/

what do i put in the node-test-commit-v8-linux config

bnoordhuis · 2018-04-13T19:38:24Z

Your username and branch name. There's a way to specify the PR but I always forget the syntax - it's something like refs/pulls/20016/head. Won't hurt to try, worst case the checkout fails and you try again.

devsnek · 2018-04-13T19:42:06Z

CI-v8 attempted: https://ci.nodejs.org/job/node-test-commit-v8-linux/1324/

MylesBorins · 2018-04-14T01:40:08Z

@devsnek is this ABI breaking?
Congrats on V8 contrib 🎉

devsnek · 2018-04-14T01:51:41Z

@MylesBorins it just adds a new method to v8::Value, that's not "breaking" right? i'll add semver-minor for new util.types method i suppose

devsnek · 2018-04-15T14:44:25Z

one last ci after rebase https://ci.nodejs.org/job/node-test-pull-request/14303/

targos · 2018-04-15T15:01:22Z

Please add Refs: https://github.com/v8/v8/commit/39d546a24022b62b00aedf7b556ac6c9e2306aab to the commit message and capitalize V8

Original commit message: [api] introduce v8::Value::IsModuleNamespaceObject This allows an embedder to check if a Value is a module namespace object. Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Idffceff451dd5f5c6a53d4cb3ce02c1c2c5b653c Reviewed-on: https://chromium-review.googlesource.com/1011762 Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{nodejs#52597} Refs: v8/v8@39d546a

devsnek · 2018-04-15T15:20:18Z

@targos done, imma just wait for these tests to finish before pushing

devsnek · 2018-04-15T16:04:41Z

failure unrelated, another ChannelClosedException

Original commit message: [api] introduce v8::Value::IsModuleNamespaceObject This allows an embedder to check if a Value is a module namespace object. Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Idffceff451dd5f5c6a53d4cb3ce02c1c2c5b653c Reviewed-on: https://chromium-review.googlesource.com/1011762 Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#52597} Refs: v8/v8@39d546a PR-URL: #20016 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

PR-URL: #20016 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

devsnek · 2018-04-15T19:48:28Z

landed as 73f13ba...c974f1b

This was missed in a previous PR PR-URL: #20105 Refs: #20016 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Original commit message: [api] introduce v8::Value::IsModuleNamespaceObject This allows an embedder to check if a Value is a module namespace object. Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Idffceff451dd5f5c6a53d4cb3ce02c1c2c5b653c Reviewed-on: https://chromium-review.googlesource.com/1011762 Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{nodejs#52597} Refs: v8/v8@39d546a PR-URL: nodejs#20016 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

PR-URL: nodejs#20016 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

jdalton · 2018-05-08T15:17:13Z

Probably should have only exposed this with --experimental-modules.
I believe this may be the only API related to experimental modules that is now public (unflagged).
It's currently undocumented in Node v10.

MylesBorins · 2018-05-08T16:36:13Z

@jdalton this has now landed in V8 so we can't really flag the feature. We could flag the util, do you think that makes sense?

jdalton · 2018-05-08T16:44:10Z

Yep, makes sense. l'm talking about the exposed user facing bit not v8 internals bit.

devsnek · 2018-05-08T16:44:14Z

I think it should just be documented, not flagged. there is nothing experimental about this api.

jdalton · 2018-05-08T16:52:19Z

It's only useful with experimental modules or experimental vm-modules.
Shrug, it's a wart for the foreseeable future (until ESM lands).

devsnek · 2018-05-08T17:05:45Z

without esm landing, vm.Module and c++ add-ons exist which can both produce module namespaces. I can open a pr to add the docs during my lunch break later today.

jdalton · 2018-05-08T17:08:22Z

The vm.Module is behind the --experimental-vm-modules flag
(the unit test in this commit requires it).

A flag, any flag, is fine... just probably not public unflagged at the moment.

Update:

Related PR doc which makes it officially exposed is #20616. It's marked as fast-track so if there are objections to it in favor of flagging you might raise them sooner than later.

Original commit message: [api] introduce v8::Value::IsModuleNamespaceObject This allows an embedder to check if a Value is a module namespace object. Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Idffceff451dd5f5c6a53d4cb3ce02c1c2c5b653c Reviewed-on: https://chromium-review.googlesource.com/1011762 Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{nodejs#52597} Refs: v8/v8@39d546a PR-URL: nodejs#20016 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Original commit message: [api] introduce v8::Value::IsModuleNamespaceObject This allows an embedder to check if a Value is a module namespace object. Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Idffceff451dd5f5c6a53d4cb3ce02c1c2c5b653c Reviewed-on: https://chromium-review.googlesource.com/1011762 Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#52597} Refs: v8/v8@39d546a PR-URL: #20016 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins · 2018-08-07T19:11:45Z

opting to not land on v8.x

Please feel free to change the label... this may make sense to include in a larger backport of modules / vm support fo 8.x

nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Apr 13, 2018

bnoordhuis approved these changes Apr 13, 2018

View reviewed changes

This was referenced Apr 13, 2018

test: remove expectations based on v8 headers from types test #20003

Closed

vm: add dynamic import callback and streamline initialize import.meta callback to match it #19717

Closed

devsnek added util Issues and PRs related to the built-in util module. v8 engine Issues and PRs related to the V8 dependency. dont-land-on-v4.x and removed lib / src Issues and PRs related to general changes in the lib or src directory. dont-land-on-v8.x labels Apr 13, 2018

guybedford approved these changes Apr 13, 2018

View reviewed changes

cjihrig approved these changes Apr 13, 2018

View reviewed changes

devsnek added the semver-minor PRs that contain new features and should be released in the next minor version. label Apr 14, 2018

devsnek force-pushed the backport/v8-39d546a24022b62b00aedf7b556ac6c9e2306aab branch from ff9eba9 to d870fad Compare April 15, 2018 14:43

devsnek added 2 commits April 15, 2018 08:15

util: introduce types.isModuleNamespaceObject

8daa1c9

devsnek force-pushed the backport/v8-39d546a24022b62b00aedf7b556ac6c9e2306aab branch from d870fad to 8daa1c9 Compare April 15, 2018 19:44

devsnek added a commit that referenced this pull request Apr 15, 2018

util: introduce types.isModuleNamespaceObject

c974f1b

PR-URL: #20016 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

jdalton mentioned this pull request May 8, 2018

util.types.isBigInt64Array and util.types.isBigUint64Array are in Node 10 but undocumented. #20602

Closed

MylesBorins mentioned this pull request Jun 6, 2018

v10.4.0 proposal #21167

Merged

MylesBorins added the dont-land-on-v8.x label Aug 7, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps: cherry-pick 39d546a from upstream v8 #20016

deps: cherry-pick 39d546a from upstream v8 #20016

devsnek commented Apr 13, 2018 •

edited

Loading

bnoordhuis Apr 13, 2018

devsnek commented Apr 13, 2018

bnoordhuis commented Apr 13, 2018 •

edited

Loading

devsnek commented Apr 13, 2018

MylesBorins commented Apr 14, 2018

devsnek commented Apr 14, 2018 •

edited

Loading

devsnek commented Apr 15, 2018

targos commented Apr 15, 2018

devsnek commented Apr 15, 2018

devsnek commented Apr 15, 2018

devsnek commented Apr 15, 2018

jdalton commented May 8, 2018 •

edited

Loading

MylesBorins commented May 8, 2018

jdalton commented May 8, 2018

devsnek commented May 8, 2018

jdalton commented May 8, 2018 •

edited

Loading

devsnek commented May 8, 2018

jdalton commented May 8, 2018 •

edited

Loading

MylesBorins commented Aug 7, 2018

deps: cherry-pick 39d546a from upstream v8 #20016

deps: cherry-pick 39d546a from upstream v8 #20016

Conversation

devsnek commented Apr 13, 2018 • edited Loading

Checklist

bnoordhuis Apr 13, 2018

Choose a reason for hiding this comment

devsnek commented Apr 13, 2018

bnoordhuis commented Apr 13, 2018 • edited Loading

devsnek commented Apr 13, 2018

MylesBorins commented Apr 14, 2018

devsnek commented Apr 14, 2018 • edited Loading

devsnek commented Apr 15, 2018

targos commented Apr 15, 2018

devsnek commented Apr 15, 2018

devsnek commented Apr 15, 2018

devsnek commented Apr 15, 2018

jdalton commented May 8, 2018 • edited Loading

MylesBorins commented May 8, 2018

jdalton commented May 8, 2018

devsnek commented May 8, 2018

jdalton commented May 8, 2018 • edited Loading

devsnek commented May 8, 2018

jdalton commented May 8, 2018 • edited Loading

MylesBorins commented Aug 7, 2018

devsnek commented Apr 13, 2018 •

edited

Loading

bnoordhuis commented Apr 13, 2018 •

edited

Loading

devsnek commented Apr 14, 2018 •

edited

Loading

jdalton commented May 8, 2018 •

edited

Loading

jdalton commented May 8, 2018 •

edited

Loading

jdalton commented May 8, 2018 •

edited

Loading