-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: move trevnorris to TSC Emeritus #19985
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for everything Trevor!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for all you did for Node.js!
README.md
Outdated
@@ -504,8 +506,6 @@ For more information about the governance of the Node.js project, see | |||
**Tiancheng "Timothy" Gu** <timothygu99@gmail.com> (he/him) | |||
* [tniessen](https://github.com/tniessen) - | |||
**Tobias Nießen** <tniessen@tnie.de> | |||
* [trevnorris](https://github.com/trevnorris) - | |||
**Trevor Norris** <trev.norris@gmail.com> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the wrong spot to be removed from.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to see you go. Glad you'll still be around! Thanks for everything!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, Ruben correctly points out that the removal is from the wrong list....
README.md
Outdated
@@ -283,6 +283,8 @@ For more information about the governance of the Node.js project, see | |||
**Isaac Z. Schlueter** <i@izs.me> | |||
* [joshgav](https://github.com/joshgav) - | |||
**Josh Gavant** <josh.gavant@outlook.com> | |||
* [trevnorris](https://github.com/trevnorris) - | |||
**Trevor Norris** <trev.norris@gmail.com> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm...also added in the wrong place. (Lists are all alphabetical by GitHub handle.) I'll fix both of these things in a moment, assuming I have push access on the branch...
I'll still be around, but won't be able to contribute enough to merit TSC status.
68d3143
to
5341b83
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, all fixed up.
Re-running lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/508/ |
I'll still be around, but won't be able to contribute enough to merit TSC status. PR-URL: nodejs#19985 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Landed in 636bac7 |
Thanks again @trevnorris! |
Thanks for all the hard work! |
I'll still be around, but won't be able to contribute enough to merit TSC status. PR-URL: #19985 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
I'll still be around, but won't be able to contribute enough to merit TSC status. PR-URL: nodejs#19985 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
I'll still be around, but won't be able to contribute enough to merit
TSC status.
Checklist