Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: relax requirements on upgrade listener #19981

Closed
wants to merge 3 commits into from
Closed

http: relax requirements on upgrade listener #19981

wants to merge 3 commits into from

Commits on Apr 12, 2018

  1. http: relax requirements on upgrade listener 

    The http spec does not say anything about Upgrade headers making
protocol switch mandatory but Node.js implements them as if they
are. Relax the requirements to only destroy the socket if no
upgrade listener exists on the client when status code is 101.
    @apapirovski
    apapirovski committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    5722ae2 View commit details
    Browse the repository at this point in the history

  2. fixup: add requested comment

    @apapirovski
    apapirovski committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    e0cebc4 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2018

  1. fixup: reverse args order in assert

    @apapirovski
    apapirovski committed Apr 15, 2018
    Configuration menu
    Copy the full SHA
    b1e5ebd View commit details
    Browse the repository at this point in the history