Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win, tools: add nasm to boxstarter script #19950

Closed
wants to merge 1 commit into from
Closed

win, tools: add nasm to boxstarter script #19950

wants to merge 1 commit into from

Conversation

bzoz
Copy link
Contributor

@bzoz bzoz commented Apr 11, 2018

Adds NASM installation to the Boxstarter script.

Refs: #19918

Checklist

@bzoz
win, tools: add nasm to boxstarter script
81c8d74 
Adds NASM installation to the Boxstarter script.

Refs: nodejs#19918
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Apr 11, 2018
@bzoz
Copy link
Contributor Author

bzoz commented Apr 11, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/14206/

@vsemozhetbyt vsemozhetbyt added windows Issues and PRs related to the Windows platform. build Issues and PRs related to build files or the CI. labels Apr 11, 2018
@BridgeAR BridgeAR added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 11, 2018
jasnell pushed a commit that referenced this pull request Apr 14, 2018
@bzoz @jasnell
win, tools: add nasm to boxstarter script
887f4c5 
Adds NASM installation to the Boxstarter script.

Refs: #19918

PR-URL: #19950
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Apr 14, 2018

Landed in 887f4c5

@jasnell jasnell closed this Apr 14, 2018
jasnell pushed a commit that referenced this pull request Apr 16, 2018
@bzoz @jasnell
win, tools: add nasm to boxstarter script
7b46503 
Adds NASM installation to the Boxstarter script.

Refs: #19918

PR-URL: #19950
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request May 1, 2018
@bzoz @BridgeAR
win, tools: add nasm to boxstarter script
a733657 
Adds NASM installation to the Boxstarter script.

Refs: nodejs#19918

PR-URL: nodejs#19950
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 17, 2018
@bzoz @MylesBorins
win, tools: add nasm to boxstarter script
8a5c100 
Adds NASM installation to the Boxstarter script.

Refs: #19918

PR-URL: #19950
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Aug 17, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@jasnell jasnell jasnell approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bzoz @jasnell @bnoordhuis @BridgeAR @MylesBorins @vsemozhetbyt @nodejs-github-bot