doc: fix quotes mistypes in inline code blocks #19713
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes trivial invalid quotes mistypes in inline code blocks, e.g. forgotten quotes or mixed order. Whether this could be easily automatically checked in lint is a separate question: e.g. `'` is valid.
ChALkeR
added
doc
vsemozhetbyt
approved these changes
Mar 31, 2018
vsemozhetbyt
added
the
author ready
richardlau
approved these changes
Mar 31, 2018
lpinca
approved these changes
Mar 31, 2018
cjihrig
approved these changes
Mar 31, 2018
tniessen
approved these changes
Mar 31, 2018
TimothyGu
approved these changes
Mar 31, 2018
trivikr
approved these changes
Apr 1, 2018
|
Landed in 3e1dd55 |
trivikr
pushed a commit
that referenced
this pull request
Apr 1, 2018
This fixes trivial invalid quotes mistypes in inline code blocks, e.g. forgotten quotes or mixed order. Whether this could be easily automatically checked in lint is a separate question: e.g. `'` is valid. PR-URL: #19713 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 2, 2018
This fixes trivial invalid quotes mistypes in inline code blocks, e.g. forgotten quotes or mixed order. Whether this could be easily automatically checked in lint is a separate question: e.g. `'` is valid. PR-URL: #19713 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes trivial invalid quotes mistypes in inline code blocks, e.g. forgotten quotes or mixed order.
Whether this could be easily automatically checked in lint is a separate question: e.g.
`'`is valid.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes