Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cpplint warning for src/node_crypto.cc:153 Using sizeof(type). #196

Closed
wants to merge 2 commits into from
Closed

Fix cpplint warning for src/node_crypto.cc:153 Using sizeof(type). #196

wants to merge 2 commits into from

Conversation

rudi-cilibrasi
Copy link

Use sizeof(varname) instead if possible [runtime/sizeof]

@bnoordhuis
Copy link
Member

Changing the sizeof changes the meaning of the check, or at least how a human reader would interpret it. I think it'd better to just squelch the warning with // NOLINT(runtime/sizeof).

@cjihrig
Copy link
Contributor

cjihrig commented Dec 22, 2014

Closing in favor of #197

@cjihrig cjihrig closed this Dec 22, 2014
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

eti-p-doray pushed a commit to eti-p-doray/node that referenced this pull request Aug 28, 2024
…ns (nodejs#196)

* Reland: [v8] Stop using deprecated fields of v8::FastApiCallbackOptions

Two fields on the v8::FastApiCallbackOptions struct were deprecated
recently, fallback and wasm_memory. This PR removes uses of these two
fields in node.js.

This change is a refactoring and does not add new features. Therefore
existing tests should be sufficient.

* return correct type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants