Fix cpplint warning for src/node_crypto.cc:153 Using sizeof(type). #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 22, 2014 00:52
Use sizeof(varname) instead if possible [runtime/sizeof]
Member
|
Changing the sizeof changes the meaning of the check, or at least how a human reader would interpret it. I think it'd better to just squelch the warning with |
Contributor
|
Closing in favor of #197 |
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
eti-p-doray
pushed a commit
to eti-p-doray/node
that referenced
this pull request
Aug 28, 2024
…ns (nodejs#196) * Reland: [v8] Stop using deprecated fields of v8::FastApiCallbackOptions Two fields on the v8::FastApiCallbackOptions struct were deprecated recently, fallback and wasm_memory. This PR removes uses of these two fields in node.js. This change is a refactoring and does not add new features. Therefore existing tests should be sufficient. * return correct type
syg
pushed a commit
to syg/node
that referenced
this pull request
May 5, 2025
…ns (nodejs#196) * Reland: [v8] Stop using deprecated fields of v8::FastApiCallbackOptions Two fields on the v8::FastApiCallbackOptions struct were deprecated recently, fallback and wasm_memory. This PR removes uses of these two fields in node.js. This change is a refactoring and does not add new features. Therefore existing tests should be sufficient. * return correct type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use sizeof(varname) instead if possible [runtime/sizeof]