Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add missing metadata for fs.open #19585

Closed
wants to merge 1 commit into from
Closed

doc: add missing metadata for fs.open #19585

wants to merge 1 commit into from
+3 −0

Conversation

tniessen
Copy link
Member

Refs: #18801

Checklist

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Mar 25, 2018
@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 25, 2018
@trivikr
Copy link
Member

trivikr commented Mar 25, 2018

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/326/

@vsemozhetbyt
Copy link
Contributor

CI-lite 2: https://ci.nodejs.org/job/node-test-pull-request-lite/328/ (previous was aborted)

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 25, 2018
tniessen added a commit to tniessen/node that referenced this pull request Mar 25, 2018
@tniessen
doc: add missing metadata for fs.open
c1ed782 
PR-URL: nodejs#19585
Refs: nodejs#18801
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@tniessen
Copy link
Member Author

Landed in c1ed782.

@tniessen tniessen closed this Mar 25, 2018
@targos targos removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 25, 2018
targos pushed a commit that referenced this pull request Mar 27, 2018
@tniessen @targos
doc: add missing metadata for fs.open
7e9b7a5 
PR-URL: #19585
Refs: #18801
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
@tniessen @MylesBorins
doc: add missing metadata for fs.open
5975c06 
PR-URL: #19585
Refs: #18801
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
@tniessen @MylesBorins
doc: add missing metadata for fs.open
6cdd772 
PR-URL: #19585
Refs: #18801
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
@tniessen @MylesBorins
doc: add missing metadata for fs.open
1c8a7a3 
PR-URL: #19585
Refs: #18801
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 9, 2018
@tniessen @MylesBorins
doc: add missing metadata for fs.open
729dbc5 
PR-URL: #19585
Refs: #18801
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Aug 16, 2018
@tniessen @MylesBorins
doc: add missing metadata for fs.open
f57c53c 
PR-URL: #19585
Refs: #18801
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tniessen @trivikr @vsemozhetbyt @BridgeAR @targos @nodejs-github-bot