Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: track bytesWritten in C++ land #19551

Closed
wants to merge 4 commits into from

Commits on Mar 29, 2018

  1. net: track bytesWritten in C++ land

    Move tracking of `socket.bytesWritten` to C++ land.
    
    This makes it easier to provide this functionality for all
    `StreamBase` instances, and in particular should keep working
    when they have been 'consumed' in C++ in some way (e.g. for
    the network sockets that are underlying to TLS or HTTP2 streams).
    
    Also, this parallels `socket.bytesRead` a lot more now.
    addaleax committed Mar 29, 2018
    Configuration menu
    Copy the full SHA
    35b7e2f View commit details
    Browse the repository at this point in the history
  2. [squash] fix windows 🤞

    addaleax committed Mar 29, 2018
    Configuration menu
    Copy the full SHA
    0c5dea8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0b824ed View commit details
    Browse the repository at this point in the history
  4. src: clean up req.bytes tracking

    Simply always tell the caller how many bytes were written, rather
    than letting them track it.
    
    In the case of writing a string, also keep track of the bytes
    written by the earlier `DoTryWrite()`.
    
    Refs: nodejs#19562
    addaleax committed Mar 29, 2018
    Configuration menu
    Copy the full SHA
    6f6f00f View commit details
    Browse the repository at this point in the history