Skip to content

[v9.x backport] test: http2 client setNextStreamID errors #19413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[v9.x backport] test: http2 client setNextStreamID errors #19413

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Mar 17, 2018 •
edited
Loading

This also fixes the error thrown (was 'The "%s" argument is out of range').

Original PR: #18848

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@trivikr @targos
test: http2 client setNextStreamID errors
5406a53 
PR-URL: nodejs#18848
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Mar 17, 2018
@targos targos changed the base branch from master to v9.x-staging March 17, 2018 13:12
@targos targos added http2 Issues or PRs related to the http2 subsystem. v9.x and removed build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Mar 17, 2018
@targos targos mentioned this pull request Mar 17, 2018
Closed
3 tasks
@MylesBorins
Copy link
Contributor

landed in 6908b8fd62

@targos targos deleted the fix-http2-error-9.x branch October 17, 2020 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leko Leko Leko approved these changes

Assignees
No one assigned
Labels
http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@targos @MylesBorins @Leko @nodejs-github-bot @trivikr