-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
path: remove redundant function #19237
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems no regression on performance. LGTM.
CI before landing: https://ci.nodejs.org/job/node-test-pull-request/13668/ |
Landed in 4ae320f |
PR-URL: #19237 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #19237 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #19237 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
@xPaw Thanks, you are right. It was not supposed to change the behaviour. I confirm that reverting this commit fixes it. I'm preparing a fix. |
Needs to land with #19520 if it is backported. |
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesBenchmark results: