test: address unreliable test-performance #19228
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test-performance can fail due to resource constraints. Move it from parallel to sequential so it does not compete with other tests for resources. Fixes: nodejs#19197
cjihrig
approved these changes
Mar 8, 2018
JungMinu
approved these changes
Mar 8, 2018
maclover7
approved these changes
Mar 8, 2018
jasnell
approved these changes
Mar 8, 2018
TimothyGu
approved these changes
Mar 8, 2018
lpinca
approved these changes
Mar 9, 2018
lpinca
added
the
author ready
jasnell
pushed a commit
that referenced
this pull request
Mar 9, 2018
test-performance can fail due to resource constraints. Move it from parallel to sequential so it does not compete with other tests for resources. Fixes: #19197 PR-URL: #19228 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in ed8fa81 |
1 task
MylesBorins
pushed a commit
that referenced
this pull request
Mar 15, 2018
test-performance can fail due to resource constraints. Move it from parallel to sequential so it does not compete with other tests for resources. Fixes: #19197 PR-URL: #19228 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 20, 2018
test-performance can fail due to resource constraints. Move it from parallel to sequential so it does not compete with other tests for resources. Fixes: #19197 PR-URL: #19228 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
test-performance can fail due to resource constraints. Move it from parallel to sequential so it does not compete with other tests for resources. Fixes: nodejs#19197 PR-URL: nodejs#19228 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
jasnell
pushed a commit
to jasnell/node
that referenced
this pull request
Aug 17, 2018
test-performance can fail due to resource constraints. Move it from parallel to sequential so it does not compete with other tests for resources. Fixes: nodejs#19197 PR-URL: nodejs#19228 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 6, 2018
test-performance can fail due to resource constraints. Move it from parallel to sequential so it does not compete with other tests for resources. Fixes: #19197 Backport-PR-URL: #22380 PR-URL: #19228 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-performance can fail due to resource constraints. Move it from
parallel to sequential so it does not compete with other tests for
resources.
Fixes: #19197
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes