Skip to content

http2: fix flaky test-http2-https-fallback #19093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

http2: fix flaky test-http2-https-fallback #19093

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85d2cd5
http2: fix flaky test-http2-https-fallback
mcollina Mar 2, 2018
185989f
squash: linting
mcollina Mar 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 29 additions & 16 deletions test/parallel/test-http2-https-fallback.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ function onRequest(request, response) {
}));
}

function onSession(session) {
function onSession(session, next) {
const headers = {
':path': '/',
':method': 'GET',
Expand All @@ -54,6 +54,10 @@ function onSession(session) {

session.close();
this.cleanup();

if (typeof next === 'function') {
next();
}
}));
request.end();
}
Expand Down Expand Up @@ -126,22 +130,31 @@ function onSession(session) {
connect(
origin,
clientOptions,
common.mustCall(onSession.bind({ cleanup, server }))
common.mustCall(function(session) {
onSession.call({ cleanup, server },
session,
common.mustCall(testNoTls));
})
);

// HTTP/1.1 client
get(Object.assign(parse(origin), clientOptions), common.mustNotCall())
.on('error', common.mustCall(cleanup))
.end();

// Incompatible ALPN TLS client
let text = '';
tls(Object.assign({ port, ALPNProtocols: ['fake'] }, clientOptions))
.setEncoding('utf8')
.on('data', (chunk) => text += chunk)
.on('end', common.mustCall(() => {
ok(/Unknown ALPN Protocol, expected `h2` to be available/.test(text));
cleanup();
}));
function testNoTls() {
// HTTP/1.1 client
get(Object.assign(parse(origin), clientOptions), common.mustNotCall)
.on('error', common.mustCall(cleanup))
.on('error', common.mustCall(testWrongALPN))
.end();
}

function testWrongALPN() {
// Incompatible ALPN TLS client
let text = '';
tls(Object.assign({ port, ALPNProtocols: ['fake'] }, clientOptions))
.setEncoding('utf8')
.on('data', (chunk) => text += chunk)
.on('end', common.mustCall(() => {
ok(/Unknown ALPN Protocol, expected `h2` to be available/.test(text));
cleanup();
}));
}
}));
}