Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix missing param in benchmark-timers #18734

Closed
wants to merge 1 commit into from
Closed

test: fix missing param in benchmark-timers #18734

wants to merge 1 commit into from

Conversation

apapirovski
Copy link
Member

When a new benchmark was added to timers, the test running these benchmarks was not updated to include the new n parameter.

Fixes: #18730

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@apapirovski apapirovski added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 12, 2018
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 12, 2018
@apapirovski
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/13124/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 12, 2018
@benjamingr
Copy link
Member

Something seems to be off in the CI, doesn't look related but maybe I missed it

@apapirovski
Copy link
Member Author

@benjamingr Build infra has been flaky for a while now (rather than just the usual flaky tests)... not really sure what's going on exactly.

@BridgeAR
Copy link
Member

It is definitely not related. We just have massive failures on our CI... See #18660

@BridgeAR
Copy link
Member

Landed in a27e443

@BridgeAR BridgeAR closed this Feb 12, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Feb 12, 2018
@apapirovski @BridgeAR
test: fix missing param in benchmark-timers
a27e443 
PR-URL: nodejs#18734
Fixes: nodejs#18730
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@apapirovski @MylesBorins
test: fix missing param in benchmark-timers
8ba9c67 
PR-URL: #18734
Fixes: #18730
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@apapirovski @MylesBorins
test: fix missing param in benchmark-timers
4d90705 
PR-URL: #18734
Fixes: #18730
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 21, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@apapirovski @MylesBorins
test: fix missing param in benchmark-timers
6c04163 
PR-URL: #18734
Fixes: #18730
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@apapirovski @MayaLekova
test: fix missing param in benchmark-timers
df11197 
PR-URL: nodejs#18734
Fixes: nodejs#18730
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
@apapirovski @MylesBorins
test: fix missing param in benchmark-timers
ec50db1 
PR-URL: #18734
Fixes: #18730
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
rvagg pushed a commit that referenced this pull request Aug 16, 2018
@apapirovski @rvagg
test: fix missing param in benchmark-timers
1654b12 
PR-URL: #18734
Fixes: #18730
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky test-benchmark-timers
5 participants
@apapirovski @benjamingr @BridgeAR @MylesBorins @nodejs-github-bot