Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: use _final instead of on('finish') #18609

Closed
wants to merge 1 commit into from
Closed

http2: use _final instead of on('finish') #18609

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Feb 7, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

net

@nodejs-github-bot nodejs-github-bot added dont-land-on-v4.x http2 Issues or PRs related to the http2 subsystem. labels Feb 7, 2018
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 10, 2018
@BridgeAR
Copy link
Member

BridgeAR commented Feb 10, 2018 •
edited
Loading

CI https://ci.nodejs.org/job/node-test-pull-request/13090/

@addaleax
Copy link
Member Author

New CI: https://ci.nodejs.org/job/node-test-commit/16162/

@BridgeAR
Copy link
Member

@addaleax is this semver-minor?

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Feb 12, 2018
@addaleax @BridgeAR
http2: use _final instead of on('finish')
377cfd6 
PR-URL: nodejs#18609
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@BridgeAR
Copy link
Member

Landed in 377cfd6 🎉

@BridgeAR BridgeAR closed this Feb 12, 2018
@addaleax addaleax deleted the http2-final branch February 12, 2018 16:11
@addaleax
Copy link
Member Author

@BridgeAR No, it’s just changing internals. Thanks for landing this!

@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 12, 2018
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@addaleax @MylesBorins
http2: use _final instead of on('finish')
84c95c5 
PR-URL: #18609
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@addaleax @MylesBorins
http2: use _final instead of on('finish')
5e778b4 
PR-URL: #18609
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@MylesBorins MylesBorins mentioned this pull request Feb 21, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@addaleax @MylesBorins
http2: use _final instead of on('finish')
5e5276b 
PR-URL: #18609
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
kjin pushed a commit to kjin/node that referenced this pull request May 1, 2018
@addaleax @kjin
http2: use _final instead of on('finish')
7b03c17 
PR-URL: nodejs#18609
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request May 2, 2018
@addaleax @MylesBorins
http2: use _final instead of on('finish')
28a2729 
Backport-PR-URL: #20456
PR-URL: #18609
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@MylesBorins MylesBorins mentioned this pull request May 2, 2018
Merged
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@addaleax @MayaLekova
http2: use _final instead of on('finish')
b018fd1 
PR-URL: nodejs#18609
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request May 15, 2018
@addaleax @MylesBorins
http2: use _final instead of on('finish')
b895ca9 
Backport-PR-URL: #20456
PR-URL: #18609
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request May 15, 2018
@addaleax @MylesBorins
http2: use _final instead of on('finish')
20fb59f 
Backport-PR-URL: #20456
PR-URL: #18609
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@apapirovski apapirovski apapirovski approved these changes

Assignees
No one assigned
Labels
http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@addaleax @BridgeAR @apapirovski @jasnell @nodejs-github-bot