Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mark test-inspector-stop-profile-after-done flaky #18491

Merged
merged 1 commit into from
Feb 1, 2018
Merged

test: mark test-inspector-stop-profile-after-done flaky #18491

merged 1 commit into from
Feb 1, 2018

Conversation

MylesBorins
Copy link
Contributor

This test is consistently failing and making CI red.

Refs: #16772

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 1, 2018
@MylesBorins
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/12865/

@MylesBorins MylesBorins mentioned this pull request Feb 1, 2018
Closed
@MylesBorins
Copy link
Contributor Author

I would like to fast track this

@joyeecheung joyeecheung added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 1, 2018
@MylesBorins
Copy link
Contributor Author

one more CI

https://ci.nodejs.org/job/node-test-pull-request/12873/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 1, 2018
@MylesBorins
test: mark test-inspector-stop-profile-after-done flaky
a36b47b 
This test is consistently failing and making CI red.

PR-URL: nodejs#18491
Refs: nodejs#16772
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins
Copy link
Contributor Author

landed in a36b47b

@MylesBorins MylesBorins closed this Feb 1, 2018
@MylesBorins MylesBorins merged commit a36b47b into nodejs:master Feb 1, 2018
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 4, 2018
MylesBorins added a commit that referenced this pull request Feb 7, 2018
@MylesBorins
test: mark test-inspector-stop-profile-after-done flaky
4746bbf 
This test is consistently failing and making CI red.

PR-URL: #18491
Refs: #16772
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins added a commit that referenced this pull request Feb 7, 2018
@MylesBorins
test: mark test-inspector-stop-profile-after-done flaky
076ca9f 
This test is consistently failing and making CI red.

PR-URL: #18491
Refs: #16772
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 7, 2018
Merged
MylesBorins added a commit that referenced this pull request Feb 11, 2018
@MylesBorins
test: mark test-inspector-stop-profile-after-done flaky
d97376f 
This test is consistently failing and making CI red.

PR-URL: #18491
Refs: #16772
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins added a commit that referenced this pull request Feb 12, 2018
@MylesBorins
test: mark test-inspector-stop-profile-after-done flaky
69271a6 
This test is consistently failing and making CI red.

PR-URL: #18491
Refs: #16772
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins added a commit that referenced this pull request Feb 13, 2018
@MylesBorins
test: mark test-inspector-stop-profile-after-done flaky
694828d 
This test is consistently failing and making CI red.

PR-URL: #18491
Refs: #16772
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins added a commit that referenced this pull request Feb 20, 2018
@MylesBorins
test: mark test-inspector-stop-profile-after-done flaky
3d8db8b 
This test is consistently failing and making CI red.

PR-URL: #18491
Refs: #16772
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins added a commit that referenced this pull request Feb 21, 2018
@MylesBorins
test: mark test-inspector-stop-profile-after-done flaky
ee2075f 
This test is consistently failing and making CI red.

PR-URL: #18491
Refs: #16772
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins added a commit that referenced this pull request Feb 21, 2018
@MylesBorins
test: mark test-inspector-stop-profile-after-done flaky
da0d776 
This test is consistently failing and making CI red.

PR-URL: #18491
Refs: #16772
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 21, 2018
Merged
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@MylesBorins @MayaLekova
test: mark test-inspector-stop-profile-after-done flaky
ce23fb1 
This test is consistently failing and making CI red.

PR-URL: nodejs#18491
Refs: nodejs#16772
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins deleted the mark-flake branch October 29, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Awaiting requested review from Trott

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@MylesBorins @cjihrig @gibfahn @addaleax @joyeecheung @BridgeAR @nodejs-github-bot