test: fix crypto test case to use correct encoding #17956
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The callback would have errored out anyway due to the incorrect encoding, and that error is not the point of this test case.
Can the error message check be improved so that the test only passes with the correct error? |
cjihrig
approved these changes
Jan 2, 2018
It already does not pass, but there is no reason to intentionally use an incorrect encoding here. If we really want to pass an invalid encoding, we should at least add a comment. To me, it was not obvious why the test failed with the message |
Trott
reviewed
Jan 3, 2018
| @@ -389,7 +389,7 @@ for (const test of TEST_CASES) { | |||
| assert.strictEqual(msg, test.plain); | |||
| } else { | |||
| // assert that final throws if input data could not be verified! | |||
| assert.throws(function() { decrypt.final('ascii'); }, errMessages.auth); | |||
| assert.throws(() => decrypt.final('hex'), errMessages.auth); | |||
There was a problem hiding this comment.
Micro-nit: I'd prefer we keep braces around this arrow function because it makes it clear that we're not intending to return a value here. Totally ignore me if you have strong opinions to the contrary.
jasnell
approved these changes
Jan 3, 2018
BridgeAR
approved these changes
Jan 5, 2018
BridgeAR
added
the
author ready
|
Landed in 5160dd0 |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 5, 2018
The callback would have errored out anyway due to the incorrect encoding, and that error is not the point of this test case. PR-URL: nodejs#17956 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 8, 2018
The callback would have errored out anyway due to the incorrect encoding, and that error is not the point of this test case. PR-URL: #17956 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 9, 2018
The callback would have errored out anyway due to the incorrect encoding, and that error is not the point of this test case. PR-URL: #17956 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 9, 2018
The callback would have errored out anyway due to the incorrect encoding, and that error is not the point of this test case. PR-URL: #17956 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
TimothyGu
removed
the
author ready
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2018
The callback would have errored out anyway due to the incorrect encoding, and that error is not the point of this test case. PR-URL: #17956 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2018
The callback would have errored out anyway due to the incorrect encoding, and that error is not the point of this test case. PR-URL: #17956 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Feb 11, 2018
The callback would have errored out anyway due to the incorrect encoding, and that error is not the point of this test case. PR-URL: #17956 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 12, 2018
The callback would have errored out anyway due to the incorrect encoding, and that error is not the point of this test case. PR-URL: #17956 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 13, 2018
The callback would have errored out anyway due to the incorrect encoding, and that error is not the point of this test case. PR-URL: #17956 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The callback would have errored out anyway due to the incorrect encoding, and that error is not the point of this test case.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)