Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: remove queue implementation from JSStreamWrap #17918

Closed
wants to merge 4 commits into from
Closed

lib: remove queue implementation from JSStreamWrap #17918

wants to merge 4 commits into from

Commits on Jan 4, 2018

  1. lib: remove queue implementation from JSStreamWrap 

    The streams implementation generally ensures that only one write()
call is active at a time. `JSStreamWrap` instances still kept
queue of write reqeuests in spite of that; refactor it away.

Also, fold `isAlive()` into a constant function on the native side.
    @addaleax
    addaleax committed Jan 4, 2018
    Configuration menu
    Copy the full SHA
    904e18a View commit details
    Browse the repository at this point in the history

  2. [squash] bnoordhuis comments

    @addaleax
    addaleax committed Jan 4, 2018
    Configuration menu
    Copy the full SHA
    0cf413b View commit details
    Browse the repository at this point in the history

  3. [squash] jasnell comment

    @addaleax
    addaleax committed Jan 4, 2018
    Configuration menu
    Copy the full SHA
    51e7ecc View commit details
    Browse the repository at this point in the history

  4. [squash] move away from for-const-of loop

    @addaleax
    addaleax committed Jan 4, 2018
    Configuration menu
    Copy the full SHA
    a17b0d9 View commit details
    Browse the repository at this point in the history