Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: improve release guide #17677

Merged
merged 0 commits into from
Dec 18, 2017
Merged

doc: improve release guide #17677

merged 0 commits into from
Dec 18, 2017

Conversation

evanlucas
Copy link
Contributor

Specify that $VERSION should include the v when replacing
REPLACEME in documentation. This is something I have to look up every time I cut a release, so may as well add it to the releases guide.

Checklist
Affected core subsystem(s)

doc

@jasnell jasnell added doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. labels Dec 14, 2017
@evanlucas evanlucas closed this Dec 18, 2017
@evanlucas evanlucas deleted the releaseguide branch December 18, 2017 20:21
@evanlucas evanlucas merged commit 7688a8b into nodejs:master Dec 18, 2017
@evanlucas
Copy link
Contributor Author

Landed in 7688a8b. Thanks!

MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
@evanlucas @MylesBorins
doc: improve release guide
c722b56 
Specify that $VERSION should include the `v` when replacing
REPLACEME in documentation.

PR-URL: #17677
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@evanlucas @MylesBorins
doc: improve release guide
ed9f2fe 
Specify that $VERSION should include the `v` when replacing
REPLACEME in documentation.

PR-URL: #17677
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Jan 23, 2018
@evanlucas @MylesBorins
doc: improve release guide
741e5b2 
Specify that $VERSION should include the `v` when replacing
REPLACEME in documentation.

PR-URL: #17677
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2018
@evanlucas @MylesBorins
doc: improve release guide
ffb063d 
Specify that $VERSION should include the `v` when replacing
REPLACEME in documentation.

PR-URL: #17677
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
gibfahn pushed a commit that referenced this pull request Jan 24, 2018
@evanlucas @gibfahn
doc: improve release guide
d1b224d 
Specify that $VERSION should include the `v` when replacing
REPLACEME in documentation.

PR-URL: #17677
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 11, 2018
@evanlucas @MylesBorins
doc: improve release guide
a759c8f 
Specify that $VERSION should include the `v` when replacing
REPLACEME in documentation.

PR-URL: #17677
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 12, 2018
@evanlucas @MylesBorins
doc: improve release guide
126d365 
Specify that $VERSION should include the `v` when replacing
REPLACEME in documentation.

PR-URL: #17677
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 13, 2018
@evanlucas @MylesBorins
doc: improve release guide
4cba432 
Specify that $VERSION should include the `v` when replacing
REPLACEME in documentation.

PR-URL: #17677
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@Fishrock123 Fishrock123 Fishrock123 approved these changes

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@evanlucas @danbev @jasnell @Fishrock123 @lpinca @cjihrig @MylesBorins