Skip to content

Conversation

apapirovski
Copy link
Contributor

Unbreaking the build. Would like to land almost immediately.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@apapirovski apapirovski added the doc Issues and PRs related to the documentations. label Dec 7, 2017
@nodejs-github-bot nodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. labels Dec 7, 2017
@apapirovski apapirovski requested a review from Trott December 7, 2017 00:11
@apapirovski
Copy link
Contributor Author

Copy link
Contributor

@maclover7 maclover7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maclover7 maclover7 added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Dec 7, 2017
@Trott
Copy link
Member

Trott commented Dec 7, 2017

Absolutely 👍 to fast-tracking.

@apapirovski apapirovski changed the title Fix child process md lint doc: remove unused link reference in child_process.md Dec 7, 2017
@apapirovski
Copy link
Contributor Author

Will wait for the linter to finish then land this since it has 2 approvals now.

@Trott
Copy link
Member

Trott commented Dec 7, 2017

FYI (for @apapirovski but also for any other Collaborators because I don't think it's been widely publicized), for commits like this, you can choose the node-test-pull-request-lite task which will only run the linter and (because it's fast) the tests on linux-one.

@Trott Trott mentioned this pull request Dec 7, 2017
3 tasks
@apapirovski
Copy link
Contributor Author

@Trott thanks. Good to know!

@apapirovski
Copy link
Contributor Author

Ok, we've been unbroken. Sorry about that.

Landed in c892f6f

@apapirovski apapirovski closed this Dec 7, 2017
@apapirovski apapirovski deleted the fix-child-process-md-lint branch December 7, 2017 00:19
apapirovski added a commit that referenced this pull request Dec 7, 2017
PR-URL: #17510
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 7, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
PR-URL: #17510
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
PR-URL: #17510
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
PR-URL: #17510
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
PR-URL: #17510
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants