src: fix typo in NODE_OPTIONS whitelist#17369
Closed
evanlucas wants to merge 1 commit intonodejs:masterfrom
Closed
src: fix typo in NODE_OPTIONS whitelist#17369evanlucas wants to merge 1 commit intonodejs:masterfrom
evanlucas wants to merge 1 commit intonodejs:masterfrom
Conversation
The whitelist of allowed cli flags that can be passed in the NODE_OPTIONS environment variable had --trace-events-categories, but the cli flag is actually --trace-event-categories.
nodejs-github-bot
added
the
c++
addaleax
approved these changes
Nov 28, 2017
addaleax
added
trace_events
richardlau
approved these changes
Nov 28, 2017
Contributor
Author
maclover7
approved these changes
Nov 28, 2017
gibfahn
approved these changes
Nov 28, 2017
cjihrig
approved these changes
Nov 28, 2017
addaleax
added
the
author ready
Contributor
Author
|
Thanks landing now! |
evanlucas
force-pushed
the
nodeoptionstracecat
branch
from
1218263 to
701dc9a
Compare
evanlucas
added a commit
to evanlucas/node
that referenced
this pull request
Nov 30, 2017
The whitelist of allowed cli flags that can be passed in the NODE_OPTIONS environment variable had --trace-events-categories, but the cli flag is actually --trace-event-categories. PR-URL: nodejs#17369 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Contributor
Author
|
Landed in 701dc9a. Thanks! |
addaleax
removed
the
author ready
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
The whitelist of allowed cli flags that can be passed in the NODE_OPTIONS environment variable had --trace-events-categories, but the cli flag is actually --trace-event-categories. PR-URL: #17369 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
The whitelist of allowed cli flags that can be passed in the NODE_OPTIONS environment variable had --trace-events-categories, but the cli flag is actually --trace-event-categories. PR-URL: #17369 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Dec 19, 2017
The whitelist of allowed cli flags that can be passed in the NODE_OPTIONS environment variable had --trace-events-categories, but the cli flag is actually --trace-event-categories. PR-URL: #17369 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
The whitelist of allowed cli flags that can be passed in the NODE_OPTIONS environment variable had --trace-events-categories, but the cli flag is actually --trace-event-categories. PR-URL: #17369 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The whitelist of allowed cli flags that can be passed in the
NODE_OPTIONS environment variable had --trace-events-categories,
but the cli flag is actually --trace-event-categories.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src