Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Update test-http-response-statuscode to use countdown timer #17327

Closed
wants to merge 1 commit into from
Closed

test: Update test-http-response-statuscode to use countdown timer #17327

wants to merge 1 commit into from

Conversation

daxlab
Copy link
Contributor

@daxlab daxlab commented Nov 26, 2017 •
edited by apapirovski
Loading

Refs: #17169

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 26, 2017
@mscdex mscdex added the http Issues or PRs related to the http subsystem. label Nov 26, 2017
@maclover7 maclover7 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 6, 2017
@apapirovski
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/11953/

apapirovski pushed a commit that referenced this pull request Dec 8, 2017
@daxlab @apapirovski
test: use Countdown in http-response-statuscode
f3f66a8 
PR-URL: #17327
Refs: #17169
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@apapirovski
Copy link
Member

Landed in f3f66a8

Thanks for the contribution @daxlab!

@apapirovski apapirovski closed this Dec 8, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@daxlab @MylesBorins
test: use Countdown in http-response-statuscode
f797d46 
PR-URL: #17327
Refs: #17169
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@daxlab @MylesBorins
test: use Countdown in http-response-statuscode
2a5da9c 
PR-URL: #17327
Refs: #17169
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 13, 2017
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@daxlab @gibfahn
test: use Countdown in http-response-statuscode
964cebf 
PR-URL: #17327
Refs: #17169
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@daxlab @gibfahn
test: use Countdown in http-response-statuscode
e9cacee 
PR-URL: #17327
Refs: #17169
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@daxlab @gibfahn
test: use Countdown in http-response-statuscode
90ee2b5 
PR-URL: #17327
Refs: #17169
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
@MylesBorins MylesBorins mentioned this pull request Dec 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maclover7 maclover7 maclover7 approved these changes

@apapirovski apapirovski apapirovski approved these changes

Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@daxlab @apapirovski @maclover7 @mscdex @addaleax @gibfahn @nodejs-github-bot