Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test of transform #17303

Closed
wants to merge 1 commit into from
Closed

test: add test of transform #17303

wants to merge 1 commit into from

Conversation

kt3k
Copy link
Contributor

@kt3k kt3k commented Nov 26, 2017

This is part of Nodefest's Code and Learn nodejs/code-and-learn#72

I added a test case of Transform constructor. The constructor can work without new operator, but the behavior doesn't seem covered in current test cases according to the latest coverage report ( https://coverage.nodejs.org/coverage-3a4fe7791e1c2a1b/root/_stream_transform.js.html ).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@kt3k
test: add test of transform
94ca887 
Add a test case of Transform constructor.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 26, 2017
@hiroppy hiroppy added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 26, 2017
@joyeecheung joyeecheung added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 26, 2017
@joyeecheung
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/11713/

targos
targos approved these changes Nov 26, 2017
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

landing...

targos pushed a commit that referenced this pull request Nov 26, 2017
@kt3k @targos
test: add test of stream Transform
9de15de 
Add a test case of Transform constructor without new.

PR-URL: #17303
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos
Copy link
Member

targos commented Nov 26, 2017

Landed in 9de15de

Thank you for the contribution!

@targos targos closed this Nov 26, 2017
@kt3k kt3k deleted the feature/add-transform-constructor branch November 26, 2017 11:11
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@kt3k @MylesBorins
test: add test of stream Transform
41f25db 
Add a test case of Transform constructor without new.

PR-URL: #17303
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@kt3k @MylesBorins
test: add test of stream Transform
94abefb 
Add a test case of Transform constructor without new.

PR-URL: #17303
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@kt3k @gibfahn
test: add test of stream Transform
f19eab2 
Add a test case of Transform constructor without new.

PR-URL: #17303
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@kt3k @gibfahn
test: add test of stream Transform
bdbcdeb 
Add a test case of Transform constructor without new.

PR-URL: #17303
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@kt3k @gibfahn
test: add test of stream Transform
0aca036 
Add a test case of Transform constructor without new.

PR-URL: #17303
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
@MylesBorins MylesBorins mentioned this pull request Dec 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@ronkorving ronkorving ronkorving approved these changes

@yosuke-furukawa yosuke-furukawa yosuke-furukawa approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@kt3k @joyeecheung @targos @yosuke-furukawa @ronkorving @lpinca @hiroppy @gibfahn @nodejs-github-bot