Skip to content

test: use common.crashOnUnhandledRejection #17242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

test: use common.crashOnUnhandledRejection #17242

wants to merge 1 commit into from

Conversation

@yozian
Copy link
Contributor

@yozian yozian commented Nov 22, 2017

Add common.crashOnUnhandledRejection to test/sequential/test-inspector-break-e.js

Checklist
  • [ x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [ x] commit message follows commit guidelines
Affected core subsystem(s)

@yozian
test: use common.crashOnUnhandledRejection
75da318 
Add common.crashOnUnhandledRejection to test/sequential/test-inspector-break-e.js
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 22, 2017
@gireeshpunathil gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 22, 2017
@mscdex mscdex added the inspector Issues and PRs related to the V8 inspector protocol label Nov 22, 2017
benjamingr
benjamingr approved these changes Nov 22, 2017
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@MylesBorins
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/11652/

MylesBorins
MylesBorins approved these changes Nov 23, 2017
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins
Copy link
Contributor

landed in c9b94ff with slight tweak to commit message

CI failure unrelated

MylesBorins pushed a commit that referenced this pull request Nov 26, 2017
@yozian @MylesBorins
test: use common.crashOnUnhandledRejection
c9b94ff 
Add common.crashOnUnhandledRejection to
test/sequential/test-inspector-break-e.js

PR-URL: #17242
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@yozian @MylesBorins
test: use common.crashOnUnhandledRejection
f7af54e 
Add common.crashOnUnhandledRejection to
test/sequential/test-inspector-break-e.js

PR-URL: #17242
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@yozian @MylesBorins
test: use common.crashOnUnhandledRejection
0e5ff6f 
Add common.crashOnUnhandledRejection to
test/sequential/test-inspector-break-e.js

PR-URL: #17242
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@yozian @gibfahn
test: use common.crashOnUnhandledRejection
1fab8fa 
Add common.crashOnUnhandledRejection to
test/sequential/test-inspector-break-e.js

PR-URL: #17242
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@yozian @gibfahn
test: use common.crashOnUnhandledRejection
39107d7 
Add common.crashOnUnhandledRejection to
test/sequential/test-inspector-break-e.js

PR-URL: #17242
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@benjamingr benjamingr benjamingr approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

+2 more reviewers

@apapirovski apapirovski apapirovski approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@yozian @MylesBorins @apapirovski @jasnell @benjamingr @cjihrig @gireeshpunathil @mscdex @gibfahn @nodejs-github-bot