Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: custom eslint autofix for inspector-check.js #16646

Closed
wants to merge 4 commits into from
Closed

tools: custom eslint autofix for inspector-check.js #16646

wants to merge 4 commits into from

Commits on Feb 12, 2018

  1. tools: custom eslint autofix for inspector-check.js 

    1. Adds fixer method
2. Extends test
3. Fixes merge issue

Refs: nodejs#16636
    @shobhitchittora
    shobhitchittora committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    0e860d0 View commit details
    Browse the repository at this point in the history

  2. tools: custom eslint autofix for inspector-check.js 

    1. Removes extra indentation
2. Removes array to track commomModule AST node.
3. Refactored test

Refs: nodejs#16636
    @shobhitchittora
    shobhitchittora committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    4afc45d View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2018

  1. tools: custom eslint autofix for inspector-check.js 

    Review comments + updates tests to work with fixer

Refs: nodejs#16636
    @shobhitchittora
    shobhitchittora committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    c4b5e8b View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2018

  1. tools: custom eslint autofix for inspector-check.js 

    rules-utils arguments check + spacing in test file

Refs: nodejs#16636
    @shobhitchittora
    shobhitchittora committed Feb 17, 2018
    Configuration menu
    Copy the full SHA
    3b1ce16 View commit details
    Browse the repository at this point in the history