docs: reorder steps for first timers #15898
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
found at node interactive code and learn. when you have never built, running macosx-firewall.sh gives errors as /out does not exist. reordering this after the build step in the doc will remove that error
nodejs-github-bot
added
build
Trott
added
the
code-and-learn
Trott
reviewed
Oct 8, 2017
BUILDING.md
Outdated
| * On macOS you may want to setup [firewall rules](tools/macosx-firewall.sh) | ||
| to avoid popups asking to accept incoming network connections when running tests: | ||
|
|
||
| If the path to your build directory contains a space, the build will likely fail. |
There was a problem hiding this comment.
Hi, @joeldart! Welcome and thanks for this! This line about spaces in the directory should remain where it was above. Moving the other ones seems good to me. Can you move this line back?
|
This has conflicts as e8bf4d5 landed, which aims to solve the same problem. |
|
Ah, looks like this is fixed then? I'm going to close this one, but feel free to comment (or re-open if GitHub lets you) if you think it should remain open. Happy to see @joeldart has #15848 open too so they'll still get a commit into Node.js if all goes well there (which it appears that it will--would have landed that one right now except that it needs a CI run first). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
found at node interactive code and learn.
when you have never built, running macosx-firewall.sh gives errors as
/out does not exist. reordering this after the build step in the doc
will remove that error.
Checklist
Affected core subsystem(s)
doc