Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix unassigned deprecation code #15741

Closed
wants to merge 1 commit into from
Closed

doc: fix unassigned deprecation code #15741

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Oct 2, 2017

Forgot to assign the deprecation code when landing 1f8d527

this really shouldn't need to wait the 48 hours to land.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

docs

@jasnell
doc: fix unassigned deprecation code
4fd7d78 
Forgot to assign the deprecation code when landing
1f8d527
@nodejs-github-bot nodejs-github-bot added the path Issues and PRs related to the path subsystem. label Oct 2, 2017
refack referenced this pull request Oct 2, 2017
@jasnell
path: deprecate internal _makeLong, replace
1f8d527 
Replace the internal `path._makeLong()` with a public
`path.toLongUNCPath()` method. Add documentation.

PR-URL: #14956
Ref: standard-things/esm#66
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell added a commit that referenced this pull request Oct 3, 2017
@jasnell
doc: fix unassigned deprecation code
1261b94 
Forgot to assign the deprecation code when landing
1f8d527

PR-URL: #15741
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@jasnell
Copy link
Member Author

jasnell commented Oct 3, 2017

Landed in 1261b94

@jasnell jasnell closed this Oct 3, 2017
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 4, 2017
@jasnell @addaleax
doc: fix unassigned deprecation code
51e7c56 
Forgot to assign the deprecation code when landing
1f8d527e94ad97e7db14d18406fe0e12983358cb

PR-URL: nodejs/node#15741
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@jasnell jasnell mentioned this pull request Oct 30, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
path Issues and PRs related to the path subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jasnell @refack @cjihrig @tniessen @MylesBorins @nodejs-github-bot