test: fix test-https-writable-true-after-close #15705
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test-https-writable-true-after-close fails intermittently when run with a lot of competing processes. Move it to sequential for stability. Fixes: nodejs#15700
Trott
added
http
cjihrig
approved these changes
Oct 1, 2017
JungMinu
approved these changes
Oct 1, 2017
jasnell
approved these changes
Oct 1, 2017
BridgeAR
approved these changes
Oct 1, 2017
lpinca
approved these changes
Oct 1, 2017
gibfahn
approved these changes
Oct 1, 2017
danbev
approved these changes
Oct 1, 2017
Member
|
This got a lot of LGs and I think it is not controversial at all. As this is going to help the CI I took the freedom to land this now without the typical 72 hours (on weekends). Landed in ee90959 |
BridgeAR
pushed a commit
that referenced
this pull request
Oct 1, 2017
test-https-writable-true-after-close fails intermittently when run with a lot of competing processes. Move it to sequential for stability. PR-URL: #15705 Fixes: #15700 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 3, 2017
test-https-writable-true-after-close fails intermittently when run with a lot of competing processes. Move it to sequential for stability. PR-URL: #15705 Fixes: #15700 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Oct 3, 2017
test-https-writable-true-after-close fails intermittently when run with a lot of competing processes. Move it to sequential for stability. PR-URL: #15705 Fixes: #15700 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 4, 2017
test-https-writable-true-after-close fails intermittently when run with a lot of competing processes. Move it to sequential for stability. PR-URL: nodejs/node#15705 Fixes: nodejs/node#15700 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 11, 2017
test-https-writable-true-after-close fails intermittently when run with a lot of competing processes. Move it to sequential for stability. PR-URL: #15705 Fixes: #15700 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-https-writable-true-after-close fails intermittently when run with
a lot of competing processes. Move it to sequential for stability.
Fixes: #15700
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test http