test: check that this != new.target in addon #15681
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add two checks that are there for expository reasons as much as they are sanity checks. Refs: nodejs/node-addon-api#142
nodejs-github-bot
added
addons
cjihrig
approved these changes
Sep 29, 2017
jasnell
approved these changes
Sep 29, 2017
tniessen
approved these changes
Sep 30, 2017
Member
|
Landed in 9e9c83e |
BridgeAR
pushed a commit
that referenced
this pull request
Oct 2, 2017
Add two checks that are there for expository reasons as much as they are sanity checks. PR-URL: #15681 Refs: nodejs/node-addon-api#142 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 3, 2017
Add two checks that are there for expository reasons as much as they are sanity checks. PR-URL: #15681 Refs: nodejs/node-addon-api#142 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Oct 3, 2017
Add two checks that are there for expository reasons as much as they are sanity checks. PR-URL: #15681 Refs: nodejs/node-addon-api#142 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 4, 2017
Add two checks that are there for expository reasons as much as they are sanity checks. PR-URL: nodejs/node#15681 Refs: nodejs/node-addon-api#142 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 11, 2017
Add two checks that are there for expository reasons as much as they are sanity checks. PR-URL: #15681 Refs: nodejs/node-addon-api#142 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 17, 2017
Add two checks that are there for expository reasons as much as they are sanity checks. PR-URL: #15681 Refs: nodejs/node-addon-api#142 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Oct 25, 2017
Add two checks that are there for expository reasons as much as they are sanity checks. PR-URL: #15681 Refs: nodejs/node-addon-api#142 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two checks that are there for expository reasons as much as they are
sanity checks.
Refs: nodejs/node-addon-api#142
CI: https://ci.nodejs.org/job/node-test-pull-request/10333/