zlib: migrate to internal/errors #15618
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
added
errors
nodejs-github-bot
added
errors
|
Ping @nodejs/tsc |
addaleax
approved these changes
Sep 25, 2017
BridgeAR
approved these changes
Sep 26, 2017
lib/zlib.js
Outdated
| `than 0x${kMaxLength.toString(16)} bytes`; | ||
| const { | ||
| kMaxLength | ||
| } = require('buffer'); |
There was a problem hiding this comment.
Nit - buffer is actually required before as well and that could be combined by writing
const { kMaxLength, Buffer } = require('buffer');There was a problem hiding this comment.
I'll get to that later but feel free to push a commit if you'd like
lpinca
approved these changes
Sep 26, 2017
JungMinu
approved these changes
Sep 26, 2017
80 tasks
|
@nodejs/tsc this needs some LGs |
mhdawson
reviewed
Oct 2, 2017
There was a problem hiding this comment.
This looks good except that its missing adding the tests for the new errors in: test/parallel/test-internal-errors.js
See https://github.com/nodejs/node/blob/master/doc/guides/using-internal-errors.md#testing-new-errorss
|
@jasnell can you add the tests for the new errors which are not constants. |
jasnell
force-pushed
the
zlib-internal-errors
branch
from
cd7ddb4
to
003f75e
Compare
|
@mhdawson, added |
jasnell
added a commit
that referenced
this pull request
Oct 2, 2017
PR-URL: #15618 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
|
Landed in 7489141 |
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 4, 2017
PR-URL: nodejs/node#15618 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate zlib to use internal/errors
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
zlib, errors