Skip to content

Conversation

@lpinca
Copy link
Member

@lpinca lpinca commented Sep 17, 2017

Adds the 'timeout' event to the http.ClientRequest documentation.

Fixes: #14856

Checklist
Affected core subsystem(s)

doc

Adds the `'timeout'` event to the `http.ClientRequest` documentation.

Fixes: nodejs#14856
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Sep 17, 2017
@gibfahn
Copy link
Member

gibfahn commented Sep 17, 2017

@kanongil would this have been clear for you?

@BridgeAR
Copy link
Member

Landed in 784cdad

@BridgeAR BridgeAR closed this Sep 20, 2017
BridgeAR pushed a commit that referenced this pull request Sep 20, 2017
Adds the `'timeout'` event to the `http.ClientRequest` documentation.

PR-URL: #15443
Fixes: #14856
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@lpinca lpinca deleted the gh-14856 branch September 20, 2017 12:50
jasnell pushed a commit that referenced this pull request Sep 20, 2017
Adds the `'timeout'` event to the `http.ClientRequest` documentation.

PR-URL: #15443
Fixes: #14856
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Qard pushed a commit to Qard/ayo that referenced this pull request Sep 21, 2017
Adds the `'timeout'` event to the `http.ClientRequest` documentation.

PR-URL: nodejs/node#15443
Fixes: nodejs/node#14856
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Qard pushed a commit to Qard/ayo that referenced this pull request Sep 21, 2017
Adds the `'timeout'` event to the `http.ClientRequest` documentation.

PR-URL: nodejs/node#15443
Fixes: nodejs/node#14856
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs: http.ClientRequest "timeout" event missing

7 participants