Skip to content

assert: handle sparse arrays in deepStrictEqual #15027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

assert: handle sparse arrays in deepStrictEqual #15027

wants to merge 1 commit into from

Conversation

@BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented Aug 25, 2017

Detect sparse array ends and add a fail early path for
unequal array length.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

assert

@BridgeAR
assert: handle sparse arrays in deepStrictEqual
8bf73ff 
Detect sparse array ends and add a fail early path for
unequal array length.
@nodejs-github-bot nodejs-github-bot added the assert Issues and PRs related to the assert subsystem. label Aug 25, 2017
@BridgeAR
Copy link
Member Author

BridgeAR commented Aug 25, 2017

CI https://ci.nodejs.org/job/node-test-pull-request/9833

Trott
Trott approved these changes Aug 25, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as CI doesn't reveal anything unexpected.

@BridgeAR
Copy link
Member Author

BridgeAR commented Aug 25, 2017 •
edited
Loading

Note: If anyone wonders - sparse arrays are already compared right now besides the case where the hole is at the end of the array. Therefore this is just a simple bug fix.

@BridgeAR
Copy link
Member Author

BridgeAR commented Aug 29, 2017

Landed in 4381100

@BridgeAR BridgeAR closed this Aug 29, 2017
BridgeAR added a commit that referenced this pull request Aug 29, 2017
@BridgeAR
assert: handle sparse arrays in deepStrictEqual
4381100 
Detect sparse array ends and add a fail early path for
unequal array length.

PR-URL: #15027
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
ghost pushed a commit to ayojs/ayo that referenced this pull request Aug 30, 2017
@BridgeAR
assert: handle sparse arrays in deepStrictEqual
55058f2 
Detect sparse array ends and add a fail early path for
unequal array length.

PR-URL: nodejs/node#15027
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
ghost pushed a commit to ayojs/ayo that referenced this pull request Aug 30, 2017
@BridgeAR
assert: handle sparse arrays in deepStrictEqual
2a3d73f 
Detect sparse array ends and add a fail early path for
unequal array length.

PR-URL: nodejs/node#15027
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
cjihrig pushed a commit to cjihrig/node that referenced this pull request Aug 31, 2017
@BridgeAR @cjihrig
assert: handle sparse arrays in deepStrictEqual
9437c18 
Detect sparse array ends and add a fail early path for
unequal array length.

PR-URL: nodejs#15027
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins pushed a commit that referenced this pull request Sep 10, 2017
@BridgeAR @MylesBorins
assert: handle sparse arrays in deepStrictEqual
ff891d4 
Detect sparse array ends and add a fail early path for
unequal array length.

PR-URL: #15027
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@MylesBorins MylesBorins mentioned this pull request Sep 10, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Sep 12, 2017
@BridgeAR @MylesBorins
assert: handle sparse arrays in deepStrictEqual
7174dc2 
Detect sparse array ends and add a fail early path for
unequal array length.

PR-URL: #15027
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@MylesBorins
Copy link
Contributor

MylesBorins commented Sep 20, 2017

This does not land cleanly in LTS. Please feel free to manually backport by following the guide. Please also feel free to replace do-not-land if it is being backported

@BridgeAR BridgeAR deleted the assert-sparse-arrays branch April 1, 2019 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

+2 more reviewers

@hiroppy hiroppy hiroppy approved these changes

@daxlab daxlab daxlab approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

assert Issues and PRs related to the assert subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@BridgeAR @MylesBorins @jasnell @Trott @cjihrig @tniessen @hiroppy @daxlab @nodejs-github-bot