fix --prof-process --preprocess flag

[davidmarkclements]

Checklist

• tests and/or benchmarks are included
• commit message follows commit guidelines

Affected core subsystem(s)

tools

This is a one-line fix to prevent the --preprocess
option (used with --prof-process to output JSON)
to cause an isolate log file profiling process to crash.

[davidmarkclements]

cc @mcollina @jasnell @MylesBorins

[mcollina]

CI: https://ci.nodejs.org/job/node-test-pull-request/9784/

[mcollina]

Linting is failing.

[davidmarkclements]

sorry - fixed

[mcollina]

CI: https://ci.nodejs.org/job/node-test-pull-request/9786/

[mcollina]

LGTM

[mcollina]

CI is green

[jasnell]

Landed in 7c948ce

[mscdex]

I just noticed this landed without a prefix in the commit message. You might consider using a git hook (such as core-validate-commit) to prevent such errors in the future.

[MylesBorins]

The test appears to time out on v6.x

Is this commit applicable to that branch?

[MylesBorins]

ping

[davidmarkclements]

The v8 version on the Node 6 branch does not appear to support the --preprocess flag

What's the appropriate way to ensure a test doesn't run against the v6.x branch?

---

On Node 8.7.0:

node --prof-process --help isolate-0x102801600-v8.log
Testing v8 version different from logging version
Cmdline args: [options] [log-file-name]
Default log file name is "v8.log".

Options:
  -j, --js             Show only ticks from JS VM state
  -g, --gc             Show only ticks from GC VM state
  -c, --compiler       Show only ticks from COMPILER VM state
  -o, --other          Show only ticks from OTHER VM state
  -e, --external       Show only ticks from EXTERNAL VM state
  --filter-runtime-timer Show only ticks matching the given runtime timer scope
  --call-graph-size    Set the call graph size
  --ignore-unknown     Exclude ticks of unknown code entries from processing
  --separate-ic        Separate IC entries
  --separate-bytecodes Separate Bytecode entries
  --separate-builtins  Separate Builtin entries
  --separate-stubs     Separate Stub entries
  --unix               Specify that we are running on *nix platform
  --windows            Specify that we are running on Windows platform
  --mac                Specify that we are running on Mac OS X platform
  --nm                 Specify the 'nm' executable to use (e.g. --nm=/my_dir/nm)
  --target             Specify the target root directory for cross environment
  --range              Specify the range limit as [start],[end]
  --distortion         Specify the logging overhead in picoseconds
  --source-map         Specify the source map that should be used for output
  --timed-range        Ignore ticks before first and after last Date.now() call
  --pairwise-timed-range, --ptr Ignore ticks outside pairs of Date.now() calls
  --only-summary       Print only tick summary, exclude other information
  --preprocess         Preprocess for consumption with web interface

On Node 6.11.4:

node --prof-process --help isolate-0x102801600-v8.log
Testing v8 version different from logging version
Cmdline args: [options] [log-file-name]
Default log file name is "v8.log".

Options:
  -j, --js             Show only ticks from JS VM state
  -g, --gc             Show only ticks from GC VM state
  -c, --compiler       Show only ticks from COMPILER VM state
  -o, --other          Show only ticks from OTHER VM state
  -e, --external       Show only ticks from EXTERNAL VM state
  --call-graph-size    Set the call graph size
  --ignore-unknown     Exclude ticks of unknown code entries from processing
  --separate-ic        Separate IC entries
  --unix               Specify that we are running on *nix platform
  --windows            Specify that we are running on Windows platform
  --mac                Specify that we are running on Mac OS X platform
  --nm                 Specify the 'nm' executable to use (e.g. --nm=/my_dir/nm)
  --target             Specify the target root directory for cross environment
  --range              Specify the range limit as [start],[end]
  --distortion         Specify the logging overhead in picoseconds
  --source-map         Specify the source map that should be used for output
  --timed-range        Ignore ticks before first and after last Date.now() call
  --pairwise-timed-range, --ptr Ignore ticks outside pairs of Date.now() calls
  --only-summary       Print only tick summary, exclude other information

[mcollina]

We just don't backport the commit to that branch. I've added the relevant tags!