src: remove duplicate loop #14750
Closed
src: remove duplicate loop #14750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two identical `while` loops after each other can be folded into a single one.
nodejs-github-bot
added
the
c++
addaleax
added
dont-land-on-v4.x
lib / src
bnoordhuis
approved these changes
Aug 10, 2017
There was a problem hiding this comment.
Hah, there used to be a chunk of code in between but 1e44fd9 removed it. LGTM.
cjihrig
approved these changes
Aug 10, 2017
evanlucas
approved these changes
Aug 10, 2017
jasnell
approved these changes
Aug 10, 2017
lpinca
approved these changes
Aug 11, 2017
danbev
approved these changes
Aug 11, 2017
XadillaX
approved these changes
Aug 11, 2017
tniessen
approved these changes
Aug 11, 2017
TimothyGu
approved these changes
Aug 11, 2017
targos
approved these changes
Aug 11, 2017
|
This doesn’t need to wait 48 hours, landed in 39c67f4 |
addaleax
added a commit
that referenced
this pull request
Aug 11, 2017
Two identical `while` loops after each other can be folded into a single one. PR-URL: #14750 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Khaidi Chu <i@2333.moe>
addaleax
added a commit
that referenced
this pull request
Aug 12, 2017
Two identical `while` loops after each other can be folded into a single one. PR-URL: #14750 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Khaidi Chu <i@2333.moe>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two identical
whileloops after each other can be folded intoa single one.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src