Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

napi: Remove napi_is_construct_call and introduce napi_get_new_target #14698

Closed
wants to merge 12 commits into from
Closed

napi: Remove napi_is_construct_call and introduce napi_get_new_target #14698

wants to merge 12 commits into from

Commits on Aug 16, 2017

  1. Remove napi_is_construct_call and introduce napi_get_new_target

    Sampson Gao committed Aug 16, 2017
    Configuration menu
    Copy the full SHA
    f41fdd1 View commit details
    Browse the repository at this point in the history

  2. Fix indentation typo in node_api.cc

    Sampson Gao committed Aug 16, 2017
    Configuration menu
    Copy the full SHA
    c99c54d View commit details
    Browse the repository at this point in the history

  3. Remove extra line

    Sampson Gao committed Aug 16, 2017
    Configuration menu
    Copy the full SHA
    b1a24a9 View commit details
    Browse the repository at this point in the history

  4. Remove CallbackWrapper.IsConstructCall

    Sampson Gao committed Aug 16, 2017
    Configuration menu
    Copy the full SHA
    108fe66 View commit details
    Browse the repository at this point in the history

  5. Change NULL to nullptr in addons-napi test

    Sampson Gao committed Aug 16, 2017
    Configuration menu
    Copy the full SHA
    9b83e22 View commit details
    Browse the repository at this point in the history

  6. Update n-api doc for napi_get_new_target

    Sampson Gao committed Aug 16, 2017
    Configuration menu
    Copy the full SHA
    6fe53be View commit details
    Browse the repository at this point in the history

  7. Check is construct call before calling v8::FunctionCallbackInfo::NewT… 

    …arget
    Sampson Gao committed Aug 16, 2017
    Configuration menu
    Copy the full SHA
    f8397c6 View commit details
    Browse the repository at this point in the history

  8. Fix grammar in doc

    Sampson Gao committed Aug 16, 2017
    Configuration menu
    Copy the full SHA
    2d830fc View commit details
    Browse the repository at this point in the history

  9. Use REPLACEME instead of version number

    Sampson Gao committed Aug 16, 2017
    Configuration menu
    Copy the full SHA
    ec67e17 View commit details
    Browse the repository at this point in the history

  10. Rephase using constructor call

    Sampson Gao committed Aug 16, 2017
    Configuration menu
    Copy the full SHA
    b733c78 View commit details
    Browse the repository at this point in the history

  11. Fix typo in doc

    Sampson Gao committed Aug 16, 2017
    Configuration menu
    Copy the full SHA
    f6ec28b View commit details
    Browse the repository at this point in the history

  12. Fix linter errors

    Sampson Gao committed Aug 16, 2017
    Configuration menu
    Copy the full SHA
    57e8976 View commit details
    Browse the repository at this point in the history