zlib: check cleanup return values #14673
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
added
c++
nodejs-github-bot
added
c++
2 tasks
cjihrig
approved these changes
Aug 7, 2017
refack
approved these changes
Aug 7, 2017
jasnell
approved these changes
Aug 8, 2017
tniessen
approved these changes
Aug 9, 2017
Member
Author
|
CI: https://ci.nodejs.org/job/node-test-commit/11688/ This should be ready. |
Member
Author
|
Landed in 2421984 |
addaleax
added a commit
that referenced
this pull request
Aug 10, 2017
PR-URL: #14673 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests seem to always pass without #14666, so unfortunately can’t be used as a test for that, but it should still be worth doing.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
zlib