Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: make test-tls-alert-handling more strict #14650

Closed
wants to merge 1 commit into from
Closed

test: make test-tls-alert-handling more strict #14650

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 28 additions & 21 deletions test/parallel/test-tls-alert-handling.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,33 +5,43 @@ if (!common.hasCrypto)
common.skip('missing crypto');

if (!common.opensslCli)
common.skip('node compiled without OpenSSL CLI.');
common.skip('node compiled without OpenSSL CLI');

const net = require('net');
const tls = require('tls');
const fixtures = require('../common/fixtures');

let clientClosed = false;
let errorReceived = false;
function canCloseServer() {
return clientClosed && errorReceived;
}

function loadPEM(n) {
return fixtures.readKey(`${n}.pem`);
return fixtures.readKey(`${n}.pem`, 'utf-8');
}

const opts = {
key: loadPEM('agent2-key'),
cert: loadPEM('agent2-cert')
};

const max_iter = 20;
let iter = 0;

const server = tls.createServer(opts, function(s) {
s.pipe(s);
s.on('error', function() {
// ignore error
});
const errorHandler = common.mustCall(() => {
errorReceived = true;
if (canCloseServer())
server.close();
});
const server = tls.createServer(opts, common.mustCall(function(s) {
s.pipe(s);
s.on('error', errorHandler);
}, 2));

server.listen(0, function() {
server.listen(0, common.mustCall(function() {
sendClient();
});
}));


function sendClient() {
Expand All @@ -45,15 +55,14 @@ function sendClient() {
return;
}
client.end();
server.close();
}, max_iter));
client.write('a');
client.on('error', function() {
// ignore error
});
client.on('close', function() {
server.close();
});
client.on('error', common.mustNotCall());
client.on('close', common.mustCall(function() {
clientClosed = true;
if (canCloseServer())
server.close();
}));
}


Expand All @@ -63,11 +72,9 @@ function sendBADTLSRecord() {
const client = tls.connect({
socket: socket,
rejectUnauthorized: false
}, function() {
}, common.mustCall(function() {
socket.write(BAD_RECORD);
socket.end();
});
client.on('error', function() {
// ignore error
});
}));
client.on('error', common.mustCall());
}