Skip to content

test: replace indexOf with includes #14630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
maasencioh wants to merge 1 commit into from
Closed

test: replace indexOf with includes #14630

maasencioh wants to merge 1 commit into from

Conversation

@maasencioh
Copy link
Contributor

@maasencioh maasencioh commented Aug 4, 2017

changed all the tests that the issue #12586 was relevant to

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests. labels Aug 4, 2017
@maasencioh maasencioh mentioned this pull request Aug 4, 2017
Closed
29 tasks
@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Aug 4, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/9485/

tniessen
tniessen approved these changes Aug 4, 2017
View reviewed changes
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for picking this up!

@tniessen tniessen self-assigned this Aug 4, 2017
@maasencioh
Copy link
Contributor Author

maasencioh commented Aug 6, 2017

@tniessen thank you, to be honest I've never had that many approvals in a PR 😃

@aqrln aqrln added refactor to ES6+ repl Issues and PRs related to the REPL subsystem. labels Aug 6, 2017
jasnell pushed a commit that referenced this pull request Aug 8, 2017
@maasencioh @jasnell
test: replace indexOf with includes
9564c20 
Refs: #12586
PR-URL: #14630
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
@jasnell
Copy link
Member

jasnell commented Aug 8, 2017

Landed in 9564c20

@jasnell jasnell closed this Aug 8, 2017
@maasencioh
Copy link
Contributor Author

maasencioh commented Aug 9, 2017

thank you all, that was really fast!

@maasencioh maasencioh deleted the includes_indexof branch August 9, 2017 08:25
addaleax pushed a commit that referenced this pull request Aug 10, 2017
@maasencioh @addaleax
test: replace indexOf with includes
55aba6a 
Refs: #12586
PR-URL: #14630
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
@addaleax addaleax mentioned this pull request Aug 13, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

+4 more reviewers

@TimothyGu TimothyGu TimothyGu approved these changes

@hiroppy hiroppy hiroppy approved these changes

@aqrln aqrln aqrln approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tniessen tniessen

Labels

async_hooks Issues and PRs related to the async hooks subsystem. repl Issues and PRs related to the REPL subsystem. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.