Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use ciphers supported by shared openssl #14566

Closed
wants to merge 1 commit into from

Conversation

kapouer
Copy link
Contributor

@kapouer kapouer commented Aug 1, 2017

On debian with openssl 1.1 cli, the ciphers used in those tests were
unknown.

On debian with openssl 1.1 cli, the ciphers used in those tests were
unknown.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 1, 2017
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mscdex mscdex added openssl Issues and PRs related to the OpenSSL dependency. tls Issues and PRs related to the tls subsystem. labels Aug 1, 2017
@Trott
Copy link
Member

Trott commented Aug 7, 2017

Trott pushed a commit to Trott/io.js that referenced this pull request Aug 7, 2017
On Debian with OpenSSL 1.1 CLI, the ciphers used in those tests were
unknown.

PR-URL: nodejs#14566
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Copy link
Member

Trott commented Aug 7, 2017

Landed in a974753. Thanks, @kapouer!

@Trott Trott closed this Aug 7, 2017
addaleax pushed a commit that referenced this pull request Aug 10, 2017
On Debian with OpenSSL 1.1 CLI, the ciphers used in those tests were
unknown.

PR-URL: #14566
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax addaleax mentioned this pull request Aug 13, 2017
MylesBorins pushed a commit that referenced this pull request Sep 19, 2017
On Debian with OpenSSL 1.1 CLI, the ciphers used in those tests were
unknown.

PR-URL: #14566
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
openssl Issues and PRs related to the OpenSSL dependency. test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants